pf + vimage patch

Nikos Vassiliadis nvass at
Thu Jun 6 16:47:17 UTC 2013

On 06/06/2013 02:28 PM, Gleb Smirnoff wrote:
> M> > module unload is broken:( Maybe it can be fixed at a (bit) later date?
> M>
> M> I don't think Gleb will be happy with this. Some time ago he removed
> M> some vimage related stuff to prevent crashing on module unload (see
> M> r229849). Actually your patch looks like a partial revert of that
> M> commit. So I think you need to think about this issue from start. At
> M> least it should not crash non-vimage kernel and there should be
> M> understanding how to fix it for vimage kernel. Your approach with
> M> keeping only one purge thread might make it simpler.

Unloading should be simple in the non-vimage case as well - I think.

> True. It is very much appreciated that you are working on vimage + pf,
> but breaking module unload isn't an option.
> When hacking on a part of kernel, having a possibility to avoid a reboot
> after each compile is very important.

Good point. Thank you both for your comments.


More information about the freebsd-virtualization mailing list