[patch] DEBUG_FLAGS cleanup
Erik Cederstrand
erik at cederstrand.dk
Wed Jan 23 10:46:16 UTC 2013
Den 23/01/2013 kl. 11.05 skrev Konstantin Belousov <kostikbel at gmail.com>:
> On Wed, Jan 23, 2013 at 09:23:41AM +0100, Erik Cederstrand wrote:
>> [...]
>>
>> -CFLAGS+= -g
>> +CFLAGS+= $(DEBUG_FLAGS)
>> CFLAGS+= -DGENERATOR_FILE -DHAVE_CONFIG_H
>>
>> # Override LIBIBERTY set by Makefile.inc, We use our own for
>
> This fragment catched my eye, and it is typical for the patch.
> Why do you need to add DEBUG_FLAGS to the CFLAGS manually ?
> Wouldn't share/mk magic do this automatically ?
Quite possibly. My only reason for this approach was to change as little as possible. I'll test if I can just remove the line entirely.
Thanks,
Erik
More information about the freebsd-toolchain
mailing list