[PATCH] Add missing pthread_condattr_{init,destroy} stubs to libc

[Joe Marcus Clarke]

On Fri, 2009-11-27 at 15:12 +0200, Kostik Belousov wrote:
> On Fri, Nov 27, 2009 at 12:15:18AM -0500, Joe Marcus Clarke wrote:
> > I would like permission to commit this patch which adds missing
> > pthread_condattr_{init,destroy} symbols to libc.  I think I did the
> > symbol addition correctly (and it seems to work).  Without this, the
> > weak symbols added in the libpthread-stubs port conflict with those in
> > libthr, and applications with use these symbols can crash.
> > 
> > I have temporarily hacked libpthread-stubs to fix this, but I really
> > feel these stubs should be added to libc.  I've also copied kib as he
> > has been kind enough to review my work in the past.  Thanks.
> > 
> > http://www.marcuscom.com/downloads/stubs.diff
> 
> It is FBSD_1.2 version that we use for symbols added after HEAD become
> CURRENT-9.

Done.

> 
> I think that you shall change lib/libc/libc_private.h, adding
> corresponding definitions for the PJT_CONDATTR_DESTROY/PJT_CONDATTR_INIT
> indexes.
> 
> Is the patch buildable ?

Yes, but only because my machine had the libc_private.h chunk which I
forgot in the diff.

> 
> Interesting question is whether these changes are mergeable to the
> stable branch. Possibly yes, if we declare that rtld/libc/libthr shall
> be built from the consistent source snapshot.

I would like to merge these changes to RELENG_8, RELENG_7, and RELENG_6
if possible.  Anything which depends on dbus (e.g. GNOME) will just
crash without them.  In the meantime, I have hacked libpthread-stubs,
but I really think this is the more correct fix.

http://www.marcuscom.com/downloads/stubs.diff

Thanks for the review.

Joe

-- 
Joe Marcus Clarke
FreeBSD GNOME Team      ::      gnome at FreeBSD.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/freebsd-threads/attachments/20091127/ccb91c48/attachment.pgp