[PATCH] Add missing pthread_condattr_{init, destroy} stubs to libc

Kostik Belousov kostikbel at gmail.com
Fri Nov 27 13:23:29 UTC 2009

On Fri, Nov 27, 2009 at 12:15:18AM -0500, Joe Marcus Clarke wrote:
> I would like permission to commit this patch which adds missing
> pthread_condattr_{init,destroy} symbols to libc.  I think I did the
> symbol addition correctly (and it seems to work).  Without this, the
> weak symbols added in the libpthread-stubs port conflict with those in
> libthr, and applications with use these symbols can crash.
> I have temporarily hacked libpthread-stubs to fix this, but I really
> feel these stubs should be added to libc.  I've also copied kib as he
> has been kind enough to review my work in the past.  Thanks.
> http://www.marcuscom.com/downloads/stubs.diff

It is FBSD_1.2 version that we use for symbols added after HEAD become

I think that you shall change lib/libc/libc_private.h, adding
corresponding definitions for the PJT_CONDATTR_DESTROY/PJT_CONDATTR_INIT

Is the patch buildable ?

Interesting question is whether these changes are mergeable to the
stable branch. Possibly yes, if we declare that rtld/libc/libthr shall
be built from the consistent source snapshot.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-threads/attachments/20091127/d37fa7a4/attachment.pgp

More information about the freebsd-threads mailing list