Makefiles for skip-level directories?
yaneurabeya at gmail.com
Fri Apr 4 23:28:21 UTC 2014
> On Apr 4, 2014, at 15:28, "Peel, Casey" <casey.peel at isilon.com> wrote:
> Ok, I figured it out and wrote up the following document (that is published on our internal wiki). You may take whatever you want of this for the FreeBSD wiki if you find it useful.
> Something rcattelan pointed out while doing the code review for my gpart changes that I wanted to run past you:
> <daelf> is the include bsd.own.mk to pick up MK_TESTS?
> <cpeel> yes
> <daelf> do you need to do that in the files that are not look at MK_TESTS?
> <daelf> geom/tests/Makefile ?
> <cpeel> I probably don't have to, but that's how the other Makefiles like that are done in FreeBSD, eg: src/bin/tests/Makefile
> <daelf> bsd.own.mk is included by bsd.init.mk which is included by bsd.test.mk
> <daelf> so it seems redundant
> <daelf> maybe we should ask the upstream if is correct ... might be better to leave it off vs perpetuating something that might not be right
Yeah, bsd.own.mk is redundant, but it doesn't do any harm minus a hit on the cache, and increase the file sizes a small amount.
In the event that the Makefile snippet would be removed from the included makefiles then stuff would break horribly. Plus it makes it clear that MK_TESTS is obtained from bsd.own.mk.
Just a thought :/...
More information about the freebsd-testing