12.2-RC1: RTL8251/8153 1000BASE-T seemingly stuck at 100Mbps

[sreehari]

ok I tried cherry picking the commit from head to stable/12 according to
one person's suggestion and I get some hunk failed's when i try patch -C
-p0. Is there any way I can simulate the MFC? Sorry I'm just not familiar
with svn

On Thu, Oct 8, 2020, 00:53 John-Mark Gurney <jmg at funkthat.com> wrote:

> sreehari wrote this message on Wed, Oct 07, 2020 at 23:56 -0700:
> > I see. Since I have the hardware and freebsd head seems broken on my
> > laptop, I'll try compiling stable/12 with the ure patch from head within
> > the next few days. I have gigabit internet and other machines to test the
> > ethernet with the full 1000Mbps. Are there any actions you suggest I take
> > to benchmark or stress test the hardware or make sure everything is
> working
> > properly?
>
> Nothing in particular...  iperf or iperf3 works well...  do normal
> transfers and make sure you don't see packet drops that are unexpected
> (checksumming was enabled)...  If you have vlans, use those...  Just be
> aware of any unexpected behaviors..
>
> Thanks for the additional testing!  And letting mek now that it works
> is useful!
>
> > On Wed, Oct 7, 2020, 23:36 John-Mark Gurney <jmg at funkthat.com> wrote:
> >
> > > Kurt Jaeger wrote this message on Thu, Oct 08, 2020 at 06:36 +0200:
> > > > > sreehari wrote this message on Tue, Oct 06, 2020 at 21:02 -0700:
> > > > > > I have a USB C hub that supports gigabit ethernet under any
> other OS,
> > > > > > but under FreeBSD it seems to detect it properly, but I never get
> > > > > > speeds exceeding 100Mbps transfer rate on the whole thing. Is
> this a
> > > > > > known issue? Also is there any way to check what the perceived
> link
> > > > > > speed is? I've attached dmesg.boot if that helps.
> > > > >
> > > > > This is a known issue w/ the ure driver on FreeBSD.  This has been
> > > > > fixed in -current, and in a few months I'll look at merging it to
> > > > > stable/12, but it definitly will not make the 12.2 release:
> > > > > https://reviews.freebsd.org/D25809
> > > >
> > > > The changes seem to be limited to the driver itself -- is some
> > > > structural change in 13 stopping a merge to 12.2 ?
> > >
> > > The issue is that IMO, it's too close to the release of 12.2.  It only
> > > recently got committed to 13, and so hasn't had enough time to be
> tested
> > > in more environments than mine.  There have been a few others that have
> > > tested it.
>
> --
>   John-Mark Gurney                              Voice: +1 415 225 5579
>
>      "All that I will do, has been done, All that I have, has not."
>