Error in /usr/src/release/release.sh

[Ian Lepore]

On Mon, 2017-08-14 at 14:34 +0000, Glen Barber wrote:
> On Mon, Aug 14, 2017 at 08:26:59AM -0600, Ian Lepore wrote:
> > 
> > On Mon, 2017-08-14 at 13:23 +0000, Glen Barber wrote:
> > > 
> > > On Mon, Aug 14, 2017 at 01:18:14PM +0000, Glen Barber wrote:
> > > > 
> > > > 
> > > > On Sat, Aug 12, 2017 at 05:12:02PM +0000, Bryce Edwards wrote:
> > > > > 
> > > > > 
> > > > > When trying to build a set of RELENG/11.1 release files, I'm
> > > > > getting the
> > > > > following error (tail end of output) in the release.sh run:
> > > > > -----------------------------------------------------------
> > > > > ---
> > > > > > 
> > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > Kernel build for ALLWINNER completed on Fri Aug 11
> > > > > > > > 22:24:02
> > > > > > > > UTC 2017
> > > > > -----------------------------------------------------------
> > > > > ---
> > > > > make -C /usr/src/release  obj
> > > > > make -C /usr/src/release  ftp
> > > > > `ftp' is up to date.
> > > > This makes me think a populated release directory within
> > > > ${.OBJDIR}
> > > > (i.e., /usr/obj/usr/src/release) already existed (perhaps from
> > > > a previous 11.1-RELEASE build?).
> > > > 
> > > > Could you retry after moving the release directory in the obj
> > > > tree
> > > > out
> > > > of the way?  Everything from your release.conf looks sane
> > > > otherwise.
> > > > 
> > > Actually, at second look, it seems you are missing
> > > EMBEDDEDBUILD=1 in
> > > your release.conf.  arm/armv6 targets should not create the 'ftp'
> > > directory - the SoC u-boot loader address is baked in during the
> > > world
> > > build, making it infeasible to create the ftp bits.
> > > 
> > > Glen
> > > 
> > Except the u-boot loader address hasn't actually been used for
> > about 2
> > years in arm builds.  I don't know anything about this ftp stuff or
> > what this thread is about, but I do know that UBLDR_LOADADDR is no
> > longer used in arm builds, and thus should not be preventing
> > anything
> > else from working.
> > 
> Hmm, I thought UBLDR_LOADADDR was still used.  Good to know.
> 
> Regarding ftp, the "big-iron" builds create a ftp directory as part
> of
> the release target, which contains the distribution sets used by
> various
> things such as bootonly.iso and poudriere.
> 
> That said, should we now expect that a userland build between all
> arm/armv6 SoCs to be identical (modulo any baked-in timestamps)?
> 
> Glen
> 

Hrm.  Well apparently, UBLDR_LOADADDR is no longer needed, but it is
still used when building ubldr (not ubldr.bin), and some old uboot
scripts still refer to ubldr.  So we've got to clean those up before we
can finish eliminating UBLDR_LOADADDR.

-- Ian