bsnmpd always died on HDD detach

[Miroslav Lachman]

Mikolaj Golub wrote:
> On Sun, Sep 09, 2012 at 11:56:55PM +0200, Miroslav Lachman wrote:
>> I am running bsnmpd with basic snmpd.config (only community and location
>> changed).
>>
>> When there is a problem with HDD and disk disapeared from ATA channel
>> (eg.: disc physically removed) the bsnmpd always dumps core:
>>
>> kernel: pid 1188 (bsnmpd), uid 0: exited on signal 11 (core dumped)
>>
>> I see this for a long rime on all releases of 7.x and 8.x branches (i386
>> and amd64). I did not tested 9.x.
>
> Ok, I was able to to reproduce this under qemu doing
>
>    atacontrol detach ata1

[...]

> and it crashes in disk_OS_get_ATA_disks() when the removed map entry
> is dereferenced.
>
> I am attaching the patch that fixes the issue for me.

I am glad to read that you found the bug!
The fix (patch) seems trivial - will it be commited / MFCed? :)

Thank you for your work on this problem!

Miroslav Lachman