tws bug ? (LSI SAS 9750)

[John-Mark Gurney]

Jim Harris wrote this message on Fri, Sep 21, 2012 at 20:17 -0700:
> On Fri, Sep 21, 2012 at 5:37 PM, Mike Tancsa <mike at sentex.net> wrote:
> > On 9/21/2012 8:03 PM, Jim Harris wrote:
> >>> .
> >>> then a lot of
> >>> .
> >>> (probe65:tws0:0:65:0): INQUIRY. CDB: 12 0 0 0 24 0
> >>> (probe65:tws0:0:65:0): CAM status: Invalid Target ID
> >>> (probe65:tws0:0:65:0): Error 22, Unretryable error
> >>> (probe1:tws0:0:1:0): INQUIRY. CDB: 12 0 0 0 24 0
> >>> (probe1:tws0:0:1:0): CAM status: Invalid Target ID
> >>> (probe1:tws0:0:1:0): Error 22, Unretryable error
> >>> (probe2:tws0:0:2:0): INQUIRY. CDB: 12 0 0 0 24 0
> >>> (probe2:tws0:0:2:0): CAM status: Invalid Target ID
> >>> .
> >>> .
> >>> .
> >>> (probe63:tws0:0:63:0): INQUIRY. CDB: 12 0 0 0 24 0
> >>> (probe63:tws0:0:63:0): CAM status: Invalid Target ID
> >>> (probe63:tws0:0:63:0): Error 22, Unretryable error
> >>> (probe64:tws0:0:64:0): INQUIRY. CDB: 12 0 0 0 24 0
> >>> (probe64:tws0:0:64:0): CAM status: Invalid Target ID
> >>> (probe64:tws0:0:64:0): Error 22, Unretryable error
> >>
> >> These can be ignored.  CAM is just telling you that there are no
> >> devices attached at these target IDs.
> >
> > What about a change similar to what Alexander Motin did in
> >
> > http://lists.freebsd.org/pipermail/svn-src-head/2012-June/038196.html
> 
> Ah, yes.  I was thinking you had CAM_DEBUG enabled which is why you
> were seeing this spew - but that's not the case.  This indeed should
> be fixed and not just ignored.
> 
> Seeing the attributions on Alexander's commit, you certainly seem to
> have a monopoly on controllers that exhibit this problem on FreeBSD.
> :)
> 
> I believe the CAM_LUN_INVALID here should be fixed as well, similar to
> the twa commit.  If you send me a revised patch I will commit it.

I'm seeing similar stuff on the hpt27xx driver:
(probe18:hpt27xx0:0:18:0): INQUIRY. CDB: 12 0 0 0 24 0 
(probe18:hpt27xx0:0:18:0): CAM status: Invalid Target ID
(probe18:hpt27xx0:0:18:0): Error 22, Unretryable error

Should I make a similar change in sys/dev/hpt27xx/osm_bsd.c?  Looks like
there are two CAM_TID_INVALID lines, but from reading the comments, only
the second one should change...

Correct?  If so, I'll try making the change and make sure everything
works well.

Thanks.

-- 
  John-Mark Gurney				Voice: +1 415 225 5579

     "All that I will do, has been done, All that I have, has not."