buildworld fails with clang

[Dimitry Andric]

On 2012-07-03 14:23, Olivier Smedts wrote:
> 9-STABLE fails to build with clang and *without* "NO_WERROR=" and
> "WERROR=" in /etc/make.conf. It used to work not long before :
...
> /usr/src/cddl/lib/libdtrace/../../../cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c:799:40:
> error: format specifies type 'long long' but the
>       argument has type 'int64_t' (aka 'long') [-Werror,-Wformat]
>         (void) snprintf(c, sizeof (c), ">= %lld", value);
>                                            ~~~^   ~~~~~
>                                            %ld
...
> This may be the culprit ?
> 
> # svn log -l 1 /usr/src/cddl/contrib/opensolaris/lib/libdtrace/
> ------------------------------------------------------------------------
> r237870 | pfg | 2012-07-01 06:15:14 +0200 (dim 01 jul 2012) | 8 lignes
> 
> MFC     r237624, r237714, r237716, r237860:

Yep, that is the culprit.  Unfortunately I didn't quite follow the
commit rush before code freeze, and this problem was introduced.

I've committed a fix to head (r238071), but it may take some time to MFC
to stable/9, since we've just entered code freeze.

Meanwhile, you can apply this patch:

http://svnweb.freebsd.org/base/head/cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c?view=patch&r1=238071&r2=238070&pathrev=238071