[stable 9] panic on reboot: ipmi_wd_event()
Attilio Rao
attilio at freebsd.org
Thu Aug 2 20:28:29 UTC 2012
On 8/2/12, John Baldwin <jhb at freebsd.org> wrote:
> On Wednesday, August 01, 2012 6:48:48 pm Sean Bruno wrote:
>> On Wed, 2012-08-01 at 05:53 -0700, John Baldwin wrote:
>> > Index: vfs_subr.c
>> > ===================================================================
>> > --- vfs_subr.c (revision 238969)
>> > +++ vfs_subr.c (working copy)
>> > @@ -1868,8 +1868,11 @@ sched_sync(void)
>> > continue;
>> > }
>> >
>> > - if (first_printf == 0)
>> > + if (first_printf == 0) {
>> > + mtx_unlock(&sync_mtx);
>> > wdog_kern_pat(WD_LASTVAL);
>> > + mtx_lock(&sync_mtx);
>> > + }
>> >
>> > }
>> > if (!LIST_EMPTY(gslp)) {
>> >
>> >
>> > --
>> > John Baldwin
>>
>> This definitely makes the panic go away on reboot.
>
> Attilio, does this change seem ok to you?
Thanks for asking me to review.
I think it is safe because we are going to use LIST_EMPTY() on the
global list anyway as next check.
Attilio
--
Peace can only be achieved by understanding - A. Einstein
More information about the freebsd-stable
mailing list