/usr/bin/script eating 100% cpu with portupgrade and xargs

[Adrian Wontroba]

On Tue, Oct 04, 2011 at 02:15:24PM +0300, Mikolaj Golub wrote:
> For the record. The issue has been fixed in CURRENT and the fix has
> been merged to STABLE.

At $JOB with a recent version of RELENG_8 and the new script (1.24.30.5
2011/10/04 11:08:31 trociny) I am getting hangs (system close to idle)
when running a batch job which calls portupgrade. I had two hangs, in
different places, while upgrading the first package. Process trees
below.

Reverting to an older version of script (1.24.30.4 2010/10/14 01:21:44
obrien) showed the 100% processor utilisation problem, but at least my
package build from source is running.

I won't be in a position to create a simpler test case, raise a PR or
try patches till Tuesday evening (UK) at the earliest.

hang 1

daemon  1997  0.0  0.1  3420  1152  ??  I     7:16PM   0:00.01 |-- /usr/libexec/atrun
root    1998  0.0  0.1  3676  1192  ??  IN    7:16PM   0:00.01 | `-- sh
root    1999  0.0  0.1  3676  1408  ??  IN    7:16PM   0:00.01 |   `-- /bin/sh -e /usr/local/rjis/bin/fbsd_upgrade.sh build_packages_all
root    2003  0.0  0.1  3676  1420  ??  IN    7:16PM   0:00.01 |     |-- /bin/sh -e /usr/local/rjis/bin/fbsd_upgrade.sh build_packages_all
root   71608  0.0  0.1  3676  1360  ??  IN    8:19PM   0:00.02 |     | `-- /bin/sh -e /usr/local/rjis/bin/fbsd_upgrade.sh build_portupgrade --all --force
root   71612  0.0  0.1  3676  1364  ??  IN    8:19PM   0:00.01 |     |   |-- /bin/sh -e /usr/local/rjis/bin/fbsd_upgrade.sh build_portupgrade --all --force
root   71619  0.0  3.4 43832 34820  ??  IN    8:19PM   0:13.37 |     |   | `-- ruby18: portupgrade: [1/280] jpeg-8_3 (ruby18)
root   75064  0.0  0.1  3356   800  ??  IN    8:20PM   0:00.10 |     |   |   `-- /usr/bin/script -qa /tmp/portupgrade20111007-71619-1ozbl8u-0 env UPGRADE_TOOL=portupgrade UPGRADE_PORT=jpeg-8_3 UPGRADE_PORT_VER=8_3 make BATCH=yes FETCH_BEFORE_ARGS=-q DEPENDS_TARGET=package
root   75065  0.0  0.1  2912  1236   3  INs+  8:20PM   0:00.08 |     |   |     `-- make BATCH=yes FETCH_BEFORE_ARGS=-q DEPENDS_TARGET=package
root   75182  0.0  0.1  3676  1180   3  IN+   8:20PM   0:00.01 |     |   |       `-- [sh]
root   75348  0.0  0.1  3676  1352   3  IN+   8:20PM   0:00.35 |     |   |         `-- /bin/sh ./configure --enable-shared --enable-static --prefix=/usr/local --mandir=/usr/local/man --infodir=/usr/local/info/ --build=i386-portbld-freebsd8.2
root   76047  0.0  0.1  3296   756   3  IN+   8:20PM   0:00.00 |     |   |           `-- printf %s checking whether to enable maintainer-specific portions of Makefiles...
root   71613  0.0  0.1  3296   668  ??  IN    8:19PM   0:00.01 |     |   `-- tee /home/fbsd_upgrade/build_portupgrade.log
root    2004  0.0  0.1  3296   712  ??  IN    7:16PM   0:00.05 |     `-- tee /home/fbsd_upgrade/build_packages_all.log

hang 2

root   76284  0.0  0.1  3676  1160  ??  IN    8:49PM   0:00.01 | `-- sh
root   76285  0.0  0.1  3676  1372  ??  IN    8:49PM   0:00.01 |   `-- /bin/sh -e /usr/local/rjis/bin/fbsd_upgrade.sh build_packages_all
root   76289  0.0  0.1  3676  1372  ??  IN    8:49PM   0:00.01 |     |-- /bin/sh -e /usr/local/rjis/bin/fbsd_upgrade.sh build_packages_all
root   45880  0.0  0.1  3676  1368  ??  IN    9:18PM   0:00.02 |     | `-- /bin/sh -e /usr/local/rjis/bin/fbsd_upgrade.sh build_portupgrade --all --force
root   45884  0.0  0.1  3676  1372  ??  IN    9:18PM   0:00.01 |     |   |-- /bin/sh -e /usr/local/rjis/bin/fbsd_upgrade.sh build_portupgrade --all --force
root   45891  0.0  3.5 43832 35812  ??  IN    9:18PM   0:13.27 |     |   | `-- ruby18: portupgrade: [1/280] jpeg-8_3 (ruby18)
root   49313  0.0  0.1  3356   804  ??  IN    9:19PM   0:00.10 |     |   |   `-- /usr/bin/script -qa /tmp/portupgrade20111007-45891-b2jn17-0 env UPGRADE_TOOL=portupgrade UPGRADE_PORT=jpeg-8_3 UPGRADE_PORT_VER=8_3 make BATCH=yes FETCH_BEFORE_ARGS=-q clean
root   49314  0.0  0.1  2912  1124   3- INEs+  9:19PM   0:00.06 |     |   |     `-- make BATCH=yes FETCH_BEFORE_ARGS=-q clean
root   45885  0.0  0.1  3296   668  ??  IN    9:18PM   0:00.01 |     |   `-- tee /home/fbsd_upgrade/build_portupgrade.log
root   76290  0.0  0.1  3296   668  ??  IN    8:49PM   0:00.03 |     `-- tee /home/fbsd_upgrade/build_packages_all.log
-- 
Adrian Wontroba
When in trouble, obfuscate.