[releng_7 tinderbox] failure on amd64/amd64

[Xin LI]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 11/19/10 02:00, Jeremy Chadwick wrote:
> On Fri, Nov 19, 2010 at 10:44:59AM +0000, FreeBSD Tinderbox wrote:
>> ===> usr.bin/nc (all)
>> cc -O2 -fno-strict-aliasing -pipe  -DIPSEC  -c /src/usr.bin/nc/../../contrib/netcat/netcat.c
>> /src/usr.bin/nc/../../contrib/netcat/netcat.c: In function 'remote_connect':
>> /src/usr.bin/nc/../../contrib/netcat/netcat.c:573: error: 'IP_BINDANY' undeclared (first use in this function)
>> /src/usr.bin/nc/../../contrib/netcat/netcat.c:573: error: (Each undeclared identifier is reported only once
>> /src/usr.bin/nc/../../contrib/netcat/netcat.c:573: error: for each function it appears in.)
>> *** Error code 1
> 
> This has been broken for 24 hours, and only on RELENG_7 (for all
> architectures, not just amd64), which lacks IP_BINDANY capability:
> 
> http://www.freebsd.org/cgi/cvsweb.cgi/src/contrib/netcat/netcat.c#rev1.6.2.2

Fixed in r215514.  Sorry for that.

> The committer and/or author needs to #ifdef IP_BINDANY the relevant
> setsockopt() call for the RELENG_7 branch, or even both RELENG_7 and
> RELENG_8 if they want.
> 
> This original methodology was in the code (for SO_BINDANY), but was for
> some reason removed.
> 
> http://www.freebsd.org/cgi/cvsweb.cgi/src/contrib/netcat/netcat.c.diff?r1=1.6.2.1;r2=1.6.2.2;f=h

The #ifdef's were to keep OpenBSD specific code out from build, but I
have realized later that we do have IP_BINDANY for ~ 1 year so I have
decided to utilize that feature but never realized that it was never
MFC'ed to RELENG_7 :(

Cheers,
- -- 
Xin LI <delphij at delphij.net>	http://www.delphij.net/
FreeBSD - The Power to Serve!	       Live free or die
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (FreeBSD)

iQEcBAEBCAAGBQJM5k+RAAoJEATO+BI/yjfB9YMH/iax9sXZYM9ugbKgDWu25HZs
v96qI1xgD10LS8m9YL0dpHU7pgaXLmHUPxBGlhigvIEBfyQwAOBYTfppv+WNBuzK
1esYDn2muoh3PNdPApldYkN8beX2bc/l6CHHaI0yWJuR21DExmYlsSlZwulwU1r5
Xu/maQ2tKdV8AFr5jPDoDNybHp/wdQIinnppoUeZ3RUCPfXngp0afbC7r84B5yIa
8W+fZBIDFJIGva4GPt7x3w3QKRpGyvXlExVssTUyf6uZb/v9ulsakFiQaoBPh1u5
yf898QHlB++zoSH9oeTTAeoeQDpQjcouV++Z1S5ukcP2lkY/EXrM0Nnt2Wnc4kU=
=eszP
-----END PGP SIGNATURE-----