RELENG_7 ata panic on atacontrol attach

[Alexander Motin]

Dmitry Morozovsky wrote:
> On Thu, 2 Apr 2009, Alexander Motin wrote:
> AM> Dmitry Morozovsky wrote:
> AM> > On Thu, 2 Apr 2009, Alexander Motin wrote:
> AM> > 
> AM> > AM> > ata7: reset tp2 stat0=50 stat1=00 devices=0x1<ATA_MASTER>^M
> AM> > AM> > ata7-master: pio=PIO4 wdma=WDMA2 udma=UDMA133 cable=40 wire^M
> AM> > AM> > ata7-master: pio=PIO4 wdma=WDMA2 udma=UDMA133 cable=40 wire^M
> AM> > AM> > ad: ad14 already exists; skipping it^M
> AM> > AM> > ad: ad14 already exists; skipping it^M
> AM> > AM> > ^M
> AM> > AM> > ^M
> AM> > AM> > Fatal trap 12: page fault while in kernel mode^M
> AM> > AM> AM> It looks alike to crash I have already fixed on CURRENT:
> AM> > AM> http://svn.freebsd.org/changeset/base/188464
> AM> > 
> AM> > Seems to be. Would you please ask re@ for MFC approval?
> AM> 
> AM> This is not actually a fix for original problem, but it may help to avoid
> AM> system crash. Can you confirm that it helps you, as I haven't tested it on
> AM> STABLE yet, I am doing it now. If it helps, I will ask re at .
> 
> Well, partially.  Machine survived a dozed of detach-remove-insert-attach 
> cycles (which it definitly could not before).

Merged.

> However, it it still paniced on hot-remove-insert (could not dump):
> Some other hot reinserts finished successfully.

It is probably an ATA code problem. I have reworked that part in HEAD.

> Well, at least now it is significally better that before, if one does not 
> forget to detach ata channel before reinserting the device.

-- 
Alexander Motin