new sk driver [was: nve timeout (and down) regression?]

[Pyun YongHyeon]

On Mon, May 08, 2006 at 04:53:10PM +0900, Ganbold wrote:
 > Pyun YongHyeon wrote:
 > >On Mon, May 08, 2006 at 03:51:55PM +0900, Ganbold wrote:
 > > > Pyun YongHyeon wrote:
 > > > >On Mon, May 08, 2006 at 03:13:28PM +0900, Ganbold wrote:
 > > > > > Pyun,
 > > > > > 
 > > > > > I can not apply the patch cleanly on 
 > > > > > http://people.freebsd.org/~yongari/sk/sk_test2/if_sk.c
 > > > > > What version of sk driver should I use?
 > > > > > 
 > > > >
 > > > >The patch was generated against HEAD.
 > > > >  
 > > > I see, but how can I MFC to RELENG_6? I can't build it on RELENG_6.
 > > > 
 > >
 > >Ok, copy the following files to /sys/dev/sk.(You may need to create
 > >the directory on 6.x.)
 > >>From the files in http://people.freebsd.org/~yongari/sk/sk_test2/
 > >if_sk.c         -->     /sys/dev/sk
 > >if_skreg.h      -->     /sys/dev/sk
 > >xmaciireg.h     -->     /sys/dev/sk
 > >yukonreg.h      -->     /sys/dev/sk
 > >
 > >And
 > >Makefile        -->     /sys/modules/sk
 > >  
 > Still can't compile.
 > 
 > cc -O2 -fno-strict-aliasing -pipe -Werror -D_KERNEL -DKLD_MODULE 
 > -nostdinc -I-   -I. -I@ -I@/contrib/altq -I@/../include -I/usr/include 
 > -finline-limit=8000 -fno-common  -mno-align-long-strings 
 > -mpreferred-stack-boundary=2  -mno-mmx -mno-3dnow -mno-sse -mno-sse2 
 > -ffreestanding -Wall -Wredundant-decls -Wnested-externs 
 > -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline 
 > -Wcast-qual  -fformat-extensions -std=c99 -c 
 > /usr/src/sys/modules/sk/../../dev/sk/if_sk.c
 > In file included from /usr/src/sys/modules/sk/../../dev/sk/if_sk.c:130:
 > @/dev/sk/if_skreg.h:995:15: no newline at end of file

I can't understand. There *IS* a newline at the end of file.
Checking with hd(1) shows a newline character.

If it break it should also break HEAD tinderbox too.

 > /usr/src/sys/modules/sk/../../dev/sk/if_sk.c:146: error: elements of 
 > array `sk_devs' have incomplete type
 > /usr/src/sys/modules/sk/../../dev/sk/if_sk.c:148: warning: excess 
 > elements in struct initializer
 > /usr/src/sys/modules/sk/../../dev/sk/if_sk.c:148: warning: (near 
 > initialization for `sk_devs[0]')
 > /usr/src/sys/modules/sk/../../dev/sk/if_sk.c:149: warning: excess 
 > elements in struct initializer
 > /usr/src/sys/modules/sk/../../dev/sk/if_sk.c:149: warning: (near 
 > initialization for `sk_devs[0]')
 > ...
 > 
 > Ganbold
 > > > thanks,
 > > > 
 > > > Ganbold
 > > > 
 > > > > > Ganbold
 > > > > > 
 > > > >  
 > > > 
 > >
 > >  
 > 

-- 
Regards,
Pyun YongHyeon