feedback, comments on this php-delimiter scrubbing program?

Jeffrey Goldberg jeffrey at
Tue Jun 16 21:02:56 UTC 2009

On Jun 16, 2009, at 10:30 AM, Gary Kline wrote:

> 	I thought my initial getchar() != EOF would handle that.
> 	But then there's that do-forever loop.

As I said, the most common problem people had was failing to check of  
EOF in all the places it could occur, and so looping forever.

Do not rely on the input being well formed.

>  I remember Jeffrey's
> 	post and tried a case 'EOF' or case '-1';  thar gives me
> 	compiler errors.

Look at the man page for getchar() paying close attention to the type  
of what it returns.

>> You should really take the pointers from Jeffrey Goldberg and  
>> record states
>> and decide based on the state, rather then inlined switch  
>> statements, if only
>> for readability.

Even for a very simple task, the logic of your code is very very hard  
to read.  Clarify the logic (using the idea of a "state") and you will  
find that this can be programmed very simply.


Jeffrey Goldberg              

More information about the freebsd-questions mailing list