pkgtools.conf error with portmanager

RW fbsd06 at mlists.homeunix.com
Sat Dec 2 13:52:23 PST 2006


On Saturday 02 December 2006 21:26, Garrett Cooper wrote:
> RW wrote:

> > My patch file is below.
> >
> > $ cd /usr/ports/sysutils/portmanager/ && cat files/patch-no-ruby-support
> > --- libMGPM/src/MGPMrReadConfigure.c.orig       Sat Dec  2 17:10:45 2006
> > +++ libMGPM/src/MGPMrReadConfigure.c    Sat Dec  2 17:11:37 2006
> > @@ -190,9 +190,7 @@
> >         MGmStrcpy( portupgradeFileName, PREFIXDIR );
> >         MGmStrcat( portupgradeFileName, "/sbin/portupgrade" );
> >
> > -       if( MGrIfFileExist( rubyFileName ) &&
> > -               MGrIfFileExist( pkgtoolsFileName ) &&
> > -               MGrIfFileExist( portupgradeFileName )  )
> > +       if( 0 )
> >         {
> >                 /*
> >                  *  run ruby script
>
> I assume ruby follows the same conventions as many other procedural
> languages ( 0 is false, non-0 is true). 
> 
I've no idea about ruby, the patch is to MGPMrReadConfigure.c 

> If so, why are you preventing
> the lines below if( 0 ) from running in your patch given above? Might as 
> well comment out or delete the following lines because they won't be
> evaluated and run..

True, but that would be more effort, so I might as well not; and keeping it 
simple reduces the chance of a conflict with a future patch.  And it's not as 
if anyone is ever going to permanently integrate this patch into the source 
files. 





More information about the freebsd-questions mailing list