pkgtools.conf error with portmanager

[Garrett Cooper]

RW wrote:
> On Saturday 02 December 2006 12:54, Gerard Seibert wrote:
>> I know this was reported the other day; however, I have just encountered
>> it myself. Evidently, the last 'portupgrade' update is now causing
>> 'portmanager' to issue this error message:
>>
>>
>> ** Error occured reading /usr/local/etc/pkgtools.conf:
>>          undefined method `x11base' for nil:NilClass
>> ** Error occured reading /usr/local/etc/pkgtools.conf:
>>          undefined method `x11base' for nil:NilClass
>>
>> It doesn't appear to be fatal, although I have not allowed it to run to
>> completion. Renaming the 'pkgtools.conf' file alleviates the problem.
>>
>> Perhaps someone might have a suggestion.
> 
> 
> I have a simple patch that turns the ruby support off, which is good enough 
> for me as I've alway disliked the feature. I'm not going to submit a PR as 
> someone may be using the pkgtools.conf support. The real solution is to patch 
> the ruby file pkgtools-to-portmanager.rb. If anyone wants this done, but 
> doesn't know ruby, the email address of the original author (which is not the 
> portmanager author) is in the ruby file.
> 
> My patch file is below. 
> 
> $ cd /usr/ports/sysutils/portmanager/ && cat files/patch-no-ruby-support
> --- libMGPM/src/MGPMrReadConfigure.c.orig       Sat Dec  2 17:10:45 2006
> +++ libMGPM/src/MGPMrReadConfigure.c    Sat Dec  2 17:11:37 2006
> @@ -190,9 +190,7 @@
>         MGmStrcpy( portupgradeFileName, PREFIXDIR );
>         MGmStrcat( portupgradeFileName, "/sbin/portupgrade" );
> 
> -       if( MGrIfFileExist( rubyFileName ) &&
> -               MGrIfFileExist( pkgtoolsFileName ) &&
> -               MGrIfFileExist( portupgradeFileName )  )
> +       if( 0 )
>         {
>                 /*
>                  *  run ruby script

I assume ruby follows the same conventions as many other procedural 
languages ( 0 is false, non-0 is true). If so, why are you preventing 
the lines below if( 0 ) from running in your patch given above? Might as 
well comment out or delete the following lines because they won't be 
evaluated and run..

-Garrett