[Bug 234816] [NEW PORT] sysutils/ioc: CLI tool for jail management with libioc{age,ell}

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234816

--- Comment #5 from gronke <stefan at gronke.net> ---
> Python ports should almost always be prefixed with PKGNAMEPREFIX=PYTHON_PKGNAMEPREFIX.

That is not required for this package because it is not an importable Python
module.

> NO_BUILD=yes - replace with USE_PYTHON=distutils autoplist (variable is currently defined but empty incorrectly)

The variable is empty on purpose. Although this project uses Python (and has
dependencies coming from Pip), it does not build a Python distribution.
USE_PYTHON= is indeed wanted, but the fact that no files are written to
PKGNAMEPREFIX makes it unnecessary to prefix this package with py36-*.

Otherwise users would be surprised that installing py36-ioc does not result in
availability of the according module.

> The PORTNAME is not consistent with the setup.py:name (ioc_cli)

Before the rename of bug #234812 from devel/py-ioc to devel/py-libioc this CLI
tool and the Python module had the same name. There is reason to use the Python
module libioc without installing the CLI, which is only one client using the
library.

The internal module name ioc_cli is only internally used to build the Click
command structure.

> Use USE_RC_SUBR for the rc.d script, after copying the file from WRKSRC to files/ (FILESDIR) at post-extract: time. See: https://www.freebsd.org/doc/en/books/porters-handbook/book.html#rc-scripts

Thanks for the hint, will do!

-- 
You are receiving this mail because:
You are on the CC list for the bug.