[Bug 234816] [NEW PORT] sysutils/ioc: CLI tool for jail management with libioc{age,ell}

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234816

Kubilay Kocak <koobs at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koobs at FreeBSD.org
             Status|New                         |Open
           Keywords|                            |needs-patch

--- Comment #4 from Kubilay Kocak <koobs at FreeBSD.org> ---
Some review items:

- Python ports should almost always be prefixed with
PKGNAMEPREFIX=PYTHON_PKGNAMEPREFIX. This is particularly the case with ports
(python packages) that support multiple Python versions, which is almost every
python software in existence.

- If pip isn't a *_DEPENDS, remove the commented line, or comment above the
commented line as to why it's commented (not yet ported, future reference,
whatever)

- Add python as a secondary (virtual) CATEGORIES

- NO_BUILD=yes - replace with USE_PYTHON=distutils autoplist (variable is
currently defined but empty incorrectly). Python packages that support these
mechanisms should use them in their ports, as it ensures a standard and
consistent build / installation, without manual porting. This also obviates the
need to use the custom do-install targets/entries, which are not currently
installing things into the correct places (PREFIX/lib, not in the python
site-packages dir)

- Use USE_RC_SUBR for the rc.d script, after copying the file from WRKSRC to
files/ (FILESDIR) at post-extract: time. See:
https://www.freebsd.org/doc/en/books/porters-handbook/book.html#rc-scripts

- The PORTNAME is not consistent with the setup.py:name (ioc_cli). Since the
latter should/will be registered in PyPI (sdist distribution not withstanding),
the PORTNAME should match what will eventually be its canonical name.

More broadly, there is a naming conflict/confusion created between this and the
dependent port (in bug 234812) born purely from the lack of a prefix (see
above).

I would standardize/canonicalize the upstream naming, and re-submit
patches/port names as follows (feel free to change the canonical names
themselves):

- sysutils/py-libioc (setup.py:name=libioc)
- sysutils/py-ioc (setup.py:name=ioc)

Alternatively:

- sysutils/py-libioc (setup.py:name=libioc)
- sysutils/py-ioc-cli (setup.py:name=ioc-cli)

-- 
You are receiving this mail because:
You are on the CC list for the bug.