www/squid: reconsider enabling all options

Guido Falsi mad at madpilot.net
Tue Apr 26 10:18:49 UTC 2016


On 04/26/16 10:41, Franco Fichtner wrote:
> Hi,
> 
>> On 26 Apr 2016, at 10:31 AM, Pavel Timofeev <timp87 at gmail.com> wrote:
>>
>> 2016-04-26 1:32 GMT+03:00 Nick Rogers <ncrogers at gmail.com>:
>>>
>>> I was able to fix my issue by recompiling without the TP_IP and TP_IPF
>>> options, but I believe more thought/discussion should be given to all the
>>> new options that are now enabled by default in the port.
>>
>> Do you think all three should be disabled by default, or we can enable
>> one of them mostly used?
> 
> Well, the breakage only occurs with local modified builds because the
> transparent proxy options weren't enabled at all before.
> 
> It probably needs an OPTIONS_RADIO along with TP_NONE, and others will
> have to discuss whether to use TP_IPFW or TP_PF as the main use case.  ;)

No need for a "TP_NONE" if using OPTIONS_RADIO, it allows for no option
to be selected, which implicitly means none.

A TP_NONE would be required in case the OPTIONS_SINGLE method was used,
which requires one and only one option to be selected. It can be needed
if the port requires special case in such a case, so option helpers can
be connected to the none case. But no such special care should be needed
in this situation.

-- 
Guido Falsi <mad at madpilot.net>


More information about the freebsd-ports mailing list