Pourdriere produces faulty build results due to bsd.openssl.mk bug

[Jung-uk Kim]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 04/01/2015 16:59, Yuri wrote:
> I found that packages produced by poudriere likely link with base 
> openssl, while port make likely links with the port openssl. This
> is because of the lines in bsd.openssl.mk which check for the 
> presence of openssl shared library and headers under PREFIX, and
> set WITH_OPENSSL_BASE when they aren't present. In case of port
> make files are likely present, and in case of poudriere build files
> are likely not present.
> 
> Example is ftp/curl (with GSSAPI=NONE,  OPENSSL=yes options).
> *Poudriere produces curl library, that causes VirtualBox to break*
> due to the openssl base vs. port conflicts. See recent emulation@
> ML threads. Port make produces curl library that works fine with
> VirtualBox.
> 
> I think both WITH_OPENSSL_BASE and WITH_OPENSSL_PORT should be
> retired, and code checking file presence also should be removed,
> and all ports should be made to build with an openssl port instead.
> Ports should never use base OpenSSL.
> 
> Only <100 ports touch WITH_OPENSSL_... variables. Somebody who is
> able to make such decisions and has the commit bit should bit
> should look into this. Otherwise, massively faulty package
> repositories are produces.

[Adding the maintainer to CC]

I know bsd.openssl.mk has been broken for very long time.  For example,

http://docs.freebsd.org/cgi/mid.cgi?50108FEF.3030405

However, I am not sure whether entirely removing it is the best way
going forward.

Jung-uk Kim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJVHGBMAAoJEHyflib82/FGH5cIAJKuo+LsZ6LUWwgIOAqTRF5E
OXlq/hBKa4JFqxzH3rQvwbuhpzLZglFf8cmxfOzqyv/soQhduddsh+ljodIfbfhH
JrwScfdIc6bP1lWpX3kACtlEwe4cUxm81XJiTQk/WrCom+DppXtdV6EqOxyiTj0B
UgiBYplQpihdUNgHIQL8USIQFeadZReOiUxNdNvc5EbIoO2QUbd3lAORQ96SZM5W
PRZRFMZmLyQkCNdP8oaTYE1s+heN0Rul+JPNfovVuGOIjEkclqMUVCUzhQuB7/Do
S+clMj88/sBhdoPMloThi0hI3lOgh+GjQb3McKoT7s5dhgVDEwqpfJrhS7TYYsQ=
=oY1m
-----END PGP SIGNATURE-----