WITHOUT_NLS is deprecated use NLS option instead

[olli hauer]

On 2013-12-26 11:08, Baptiste Daroussin wrote:
> On Wed, Dec 25, 2013 at 10:55:56PM -0800, Doug Barton wrote:
>> On 12/25/2013 10:51 PM, clutton wrote:
>>> Sorry, but I have a quite opposite view. Making both variants work means
>>> chaos. More variants means more complication.
>>
>> if <options for nls mean no> || WITHOUT_NLS; then
>>
>>
>> This is not chaos. It's called "backwards compatibility," which is a 
>> critical part of every mature software project.
>>
>> OTOH, forcing users to jump through stupid hoops to change 
>> configurations which have worked for over a decade is a sign of the 
>> inmates running the asylum.
>>
>> Doug
>>
> 
> Backward compatility is still in there, this is a warning to the users, so that
> they do get time to migrate. And it will stay for a while, even if
> OPTIONS_UNSET=NLS is recommanded for more than a year.
> 

I suspect the warning comes from bsd.options.mk in case NLS is unset
by the user even the new correct way.

file: Mk/bsd.options.mk
120 .if !defined(WITHOUT_NLS)
121 PORT_OPTIONS+=  NLS
122 .endif
...
347 .if empty(PORT_OPTIONS:MNLS)
348 WITHOUT_NLS=    yes
349 .endif


Now bsd.sanity.mk kicks in and complains ...

-- 
Regards,
olli