[RFC] A trivial change for DESKTOP_ENTRIES (take 2)

[Pav Lucistnik]

Jung-uk Kim píše v čt 14. 07. 2011 v 15:15 -0400:
> On Thursday 14 July 2011 01:55 pm, Stephen Montgomery-Smith wrote:
> > On 07/14/2011 12:47 PM, Jung-uk Kim wrote:
> > > Anyhow, I guess we can do it much simpler:
> > >
> > > --- Mk/bsd.port.mk      3 Jul 2011 15:51:18 -0000       1.687
> > > +++ Mk/bsd.port.mk      14 Jul 2011 17:26:43 -0000
> > > @@ -6432,7 +6432,7 @@
> > >   		${ECHO_CMD} "@cwd ${DESKTOPDIR}">>  ${TMPPLIST}; \
> > >   	fi; \
> > >   	while [ $$# -gt 6 ]; do \
> > > -		filename="`${ECHO_CMD} "$$4" | ${TR} -cd [:alnum:]`.desktop";
> > > \ +		filename="`${BASENAME} "$$4" | ${SED} -E
> > > 's/[[:space:]]+.*//'`.desktop"; \
> > > pathname="${DESKTOPDIR}/$$filename"; \
> > >   		categories="$$5"; \
> > >   		if [ -z "$$categories" ]; then \
> > >
> > > I think this is much simpler and better fix.
> > >
> > > Jung-uk Kim
> >
> > I agree.
> 
> I'll commit this version tomorrow unless I see more objection.

Eh, don't you need to get portmgr@ approval before touching bsd.port.mk
by any chance ???

I could support allowing dash as one extra allowed char, and having that
change exp-run'ed.

-- 
-- 
Pav Lucistnik <pav at oook.cz>
              <pav at FreeBSD.org>
> With a 10 MHz 386 the downloading speed would most likely drop > to a
crawl or stop with the decoding process etc. I think most 10MHz 386
users are quite accustomed to things dropping to a crawl.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20110714/d1e1faa7/attachment.pgp