math/blas linking to gfortran with LDADD?= -lgfortran

[Scot Hetzel]

On Tue, Aug 31, 2010 at 11:58 PM, b. f. <bf1783 at googlemail.com> wrote:
> On 9/1/10, Scot Hetzel <swhetzel at gmail.com> wrote:
>> On Tue, Aug 31, 2010 at 10:06 PM, b. f. <bf1783 at googlemail.com> wrote:
>>> On 8/31/10, jhell <jhell at dataix.net> wrote:
>
>>So according to bsd.own.mk, this is the correct test for the math/blas
>>port to determine if profiling libraries should be built:
>>
>>.if !defined(WITHOUT_PROFILE)
>>PLIST_FILES+=   lib/libblas_p.a
>>.endif
>
> No, you are leaving the order out of account.  Apart from local and
> custom makefiles, the makefiles are included so:
>
> /usr/share/mk/sys.mk
> /etc/make.conf
> /usr/share/mk/bsd.compat.mk
> usr/share/mk/bsd.cpu.mk
> Makefile(for math/blas)
> /usr/share/mk/bsd.port.mk
> /usr/share/mk/bsd.own.mk
> /usr/ports/Mk/bsd.port.mk
> /usr/ports/Mk/bsd.commands.mk
> /usr/ports/Mk/bsd.perl.mk
> /usr/ports/Mk/bsd.gcc.mk
> /usr/ports/Mk/bsd.perl.mk
> /usr/ports/Mk/bsd.licenses.mk
> /usr/ports/Mk/bsd.sites.mk
> ...
>
> So if NO_PROFILE or NOPROFILE is defined, a test for WITHOUT_PROFILE
> in Makefile will still fail because NO_PROFILE is not mapped to
> WITHOUT_PROFILE until bsd.own.mk, after the test.  Just be patient and
> we'll sort it out.
>
>>
>> As can be seen, NOPROFILE is deprecated.
>
> It may be deprecated, but it will still take effect without
> BURN_BRIDGES, and so still must be accounted for.
>
>>
>> NOTE: WITHOUT_PROFILE would need to be set in /etc/make.conf (instead
>> of /etc/src.conf) to disable building profiled libraries in the
>> FreeBSD sources and the math/blas port.
>
> No, it will still take effect, after the math/blas Makefile is parsed,
> unless _WITHOUT_SRCCONF is defined.  See bsd.own.mk.
>
> b.
>

I created PR 150174, before I got your reply:

http://www.freebsd.org/cgi/query-pr.cgi?pr=150174

I changed the port to use the OPTIONS framework to enable/disable
profiled libraries.  The only thing I didn't take into account was the
bsd.lib.mk was still pulling in /etc/src.conf.  To fix this we just
need to add _WITHOUT_SRCCONF to the MAKE_ARGS (should they be
MAKE_ENV?).

Scot