request for a new port review [memtest86+]

Andriy Gapon avg at icyb.net.ua
Wed Mar 11 06:42:38 PDT 2009


on 11/03/2009 15:37 Eitan Adler said the following:
> Andriy Gapon wrote:
>> Guys,
>>
>> could you please review the below port for correctness, style and general approach
>> taken by me.
> http://isis.poly.edu/~eitan/files/patch-memtest86+-port.diff
> Apply this patch then install the port "portlint" and run portlint -CNA.
> 
> Always use tabs - not spaces.

Something must have been screwed during transfer, I do have tabs not spaces here -
otherwise makefile syntax would be incorrect, nothing would work and I wouldn't
even attempt to submit such a mess.

-- 
Andriy Gapon


More information about the freebsd-ports mailing list