request for a new port review [memtest86+]
eitanadlerlist at gmail.com
Wed Mar 11 06:51:59 PDT 2009
Andriy Gapon wrote:
> on 11/03/2009 15:37 Eitan Adler said the following:
>> Andriy Gapon wrote:
>>> could you please review the below port for correctness, style and general approach
>>> taken by me.
>> Apply this patch then install the port "portlint" and run portlint -CNA.
>> Always use tabs - not spaces.
> Something must have been screwed during transfer, I do have tabs not spaces here -
> otherwise makefile syntax would be incorrect, nothing would work and I wouldn't
> even attempt to submit such a mess.
These are the commands I used to fetch and extract:
Either way run portlint -CNA. When this passes submit a PR with the
port. Also since you don't have spaces my diff won't apply but I think
you should change BOOT_DIR= /boot/opt to BOOT_DIR?= /boot/opt so the
location can be specified by the user.
"Security is increased by designing for the way humans actually behave."
More information about the freebsd-ports