Ports 104877 causing big problems

[Jean-Yves Lefort]

On Fri, 9 Mar 2007 14:34:31 -0800
Ade Lovett <ade at FreeBSD.org> wrote:

> On Mar 09, 2007, at 14:21 , Doug Barton wrote:
> > Can we have some response from Ade, and/or portmgr on when this might
> > be fixed? I would agree that the current behavior is suboptimal.
>
> I'm pretty certain that this has been addressed with recent updates
> to devel/libtool15 and devel/libltdl15 -- certainly it solved the
> gnucash problem that had a similar failure case.

No.

> The patch as it stands in 104877 is flawed in that it brings in
> bsd.autotools.mk merely with a GNU_CONFIGURE enabled and as such
> makes tree-wide changes to those ports that use this stanza, but not
> a USE_AUTOTOOLS stanza, thus giving no incentive for port maintainers
> themselves to ensure that the fixes are punted back upstream.

The patch is not flawed. bsd.autotools.mk has to be pulled in when
GNU_CONFIGURE is set because many ports use libtool and yet do not set
USE_AUTOTOOLS=libtool. The included libtool files must therefore be
patched.

> So, item (1): does the problem actually still exist with a port using
> the in-tree devel/libtool15 (via USE_AUTOTOOLS= libtool:15[:env].  If
> yes, empirical evidence will be required as an addendum to the PR.
> If no, then we're done.

No evidence is needed. Your recent commits have had no influence on
the problem and it therefore still stands. Furthermore, ports that use
their included version of libtool rather than the system libtool are
also affected.

> Item (2).  The patch as stands will not go in, since that part that
> is bsd.port.mk fundamentally violates POLA.  If such a mechanism is
> required, then it will need to be developed as an addendum to the
> existing USE_AUTOTOOLS stanza, so that it is *very* clear which ports
> need to be upstream-fixed.

If you don't like my solution, provide one yourself. You are the
maintainer, and you introduced that regression by resurrecting .la
files.

--
Jean-Yves Lefort

jylefort at FreeBSD.org
http://lefort.be.eu.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20070310/0baffa4a/attachment.pgp