Upgrade mysql50-server/client to 5.0.33

[Jeremy Chadwick]

On Mon, Jan 22, 2007 at 08:42:11AM -0800, Jeremy Chadwick wrote:
> On Mon, Jan 22, 2007 at 04:39:32PM +0100, Anders Nordby wrote:
> > Hi,
> > 
> > The following patch updates the port to 5.0.33. Time to update it?
> 
> I have to recommend against this update.  Stay with 5.0.27 for now,
> as the following bug affects InnoDB on 5.0.32 and 5.0.33:
> 
> http://bugs.mysql.com/bug.php?id=25653
> http://bugs.mysql.com/bug.php?id=25596

Anders and I have discussed this a bit.  5.0.27 has clustering-
related problems, while 5.0.33 has this InnoDB problem.  What a mess.
:-)

The InnoDB problem (and fix) is documented in MySQL Bug 25596
(comment dated 16 Jan 19:04 by Heikki Tuuri).  In
innobase/dict/dict0dict.c:

Fix:
replace
	strchr(" \v\f\t\r\n", c)
with
	(strchr(" \v\f\t\r\n", c) && c != '\0')

The official MySQL 5.0 server repository does not show signs of
this fix being applied yet.  Look for the line labelled
"#define ib_isspace(c)" here:

http://mysql.bkbits.net:8080/mysql-5.0/innobase/dict/dict0dict.c?PAGE=anno&REV=%2b

The implementation on 5.1 is very different, thus the bug doesn't
exist there.

Since there's a fix available, I'm cool with the port being upgraded
from 5.0.27 to 5.0.33 assuming we add a patch for this fix to
files/ until the MySQL guys address the problem in the official source.

-- 
| Jeremy Chadwick                                 jdc at parodius.com |
| Parodius Networking                        http://www.parodius.com/ |
| UNIX Systems Administrator                   Mountain View, CA, USA |
| Making life hard for others since 1977.               PGP: 4BD6C0CB |