[kde-freebsd] C++ issue on 4.11: kpopupmenu.h [Please review]

[Michael Nottebrock]

On Friday, 11. March 2005 11:00, Volker Stolz wrote:
> Am 10. Mar 2005 um 21:51 CET schrieb Michael Nottebrock:
> > On Thursday, 10. March 2005 13:01, Volker Stolz wrote:
> > There's an easier and quicker workaround for now: add --enable-final to
> > CONFIGURE_ARGS of kipi-plugins.
>
> s/kipi-plugins/all ports including this header/g

Hardly, this header is used by pretty much every other kde application. It 
takes some pretty bad luck and headers to produce this error - in this case 
it's caused by the tiffio.h header and its placement before any 
system-headers (which is (at least style)-buggy in itself anyway).

> Someone please just hit it over the head with a blunt stick and let's see
> what gets unbroken(!) before the ports-freeze.

Sorry, but I'm not going to hit our users over the head with a treetrunk 
(which is what a patch and subsequent PORTREVISION bump in kdelibs amounts 
to) for some whacko compilation error that can be easily worked around. If 
you don't like --enable-final, you can use the attached patch instead, too.

-- 
   ,_,   | Michael Nottebrock               | lofi at freebsd.org
 (/^ ^\) | FreeBSD - The Power to Serve     | http://www.freebsd.org
   \u/   | K Desktop Environment on FreeBSD | http://freebsd.kde.org
-------------- next part --------------
--- kipi-plugins/acquireimages/acquireimagedialog.cpp.orig	Fri Mar 11 11:53:55 2005
+++ kipi-plugins/acquireimages/acquireimagedialog.cpp	Fri Mar 11 11:53:43 2005
@@ -24,7 +24,6 @@
 
 extern "C"
 {
-#include <tiffio.h>
 #include <stdlib.h>
 #include <stdio.h>
 #include <unistd.h>
@@ -32,6 +31,7 @@
 #include <sys/stat.h>
 #include <sys/mman.h>
 #include <fcntl.h>
+#include <tiffio.h>
 }
 
 // Include files for Qt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20050311/63d1a728/attachment.bin