xview-clients port and the bento log

[Erik Trulsson]

On Sat, Sep 27, 2003 at 07:16:26PM -0700, Pedro F. Giffuni wrote:
> Hi;
> 
> I'm looking at the bento log cview-clients and it looks easy to fix but really
> weird and in a certain sense scary:
> 
> patch-aa does not apply cleanly, but it seems like a path problem:
> ..
> patch: **** can't cd to
> /tmp/a/ports/x11-toolkits/xview-clients/../xview/work/xview3.2p1-X11R6: No such
> file or directory
> 
> The patch is ugly by modern standards, it has several diffs in the same file,
> and the first diff is not necessary as it contains only newline changes, but
> the patch has been untouched since it was committed (4 years ago!).  Has this
> port been broken for 4 years??


The port itself is not quite broken (and the patch itself is fine), but
the port has a somewhat incestous relataionship with the xview port.
If you first do a 'make patch' in the xviw port, then 'make patch' in
the xview-clients port, then things will work fine. Otherwise they
won't.
This used to work automatically, but some time ago there were changes
made to the ports system as to exactly when build-time dependencies are
checked.  It used to be prior to the extract target, but was moved to
just prior to the configure target.
Things ought to work fine, since xview-clients DEPENDS on xview, but
it doesn't work right for some reason.

Anyway, the problem lies in how xview-clients depends on xview.
(And in the fact that both these ports seem quite dusty and in need of
a complete overhaul to have them updated to modern ports-practice, but
that seems like a lot of work.)

The following patch to xview-clients seems to make the patches apply
cleanly, but I am not at all sure if this is the right way to solve the
problem:


Index: Makefile
===================================================================
RCS file: /ncvs/ports/x11-toolkits/xview-clients/Makefile,v
retrieving revision 1.27
diff -u -r1.27 Makefile
--- Makefile	20 Feb 2003 19:20:28 -0000	1.27
+++ Makefile	28 Sep 2003 07:03:28 -0000
@@ -18,6 +18,7 @@
 COMMENT=	OpenLook applications and man pages
 
 DEPENDS=	${PORTSDIR}/x11-toolkits/xview:install
+PATCH_DEPENDS=	/nonexistent:${PORTSDIR}/x11-toolkits/xview:patch
 
 USE_X_PREFIX=	yes
 EXTRACT_ONLY=	# empty






-- 
<Insert your favourite quote here.>
Erik Trulsson
ertr1013 at student.uu.se