[Bug 213904] [maintainer] [patch] games/zdoom: Add desktop and pixmap files

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=213904

--- Comment #3 from Jan Beich (mail not working) <jbeich at FreeBSD.org> ---
Comment on attachment 176787
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=176787
svn(1) diff of games/zdoom

> +DESKTOP_ENTRIES=	"ZDoom" "${COMMENT}" "${PORTNAME}" "${PORTNAME}" "Game;" ${FALSE}

Don't use ${FALSE} variable if the value isn't supposed to be a command (e.g.
/usr/bin/false) or sh(1) builtin. Besides, "false" isn't actually default
behavior for StartupNotify:

  If true, it is KNOWN that the application will send a "remove"
  message when started with the DESKTOP_STARTUP_ID environment
  variable set. If false, it is KNOWN that the application does not
  work with startup notification at all (does not shown any window,
  breaks even when using StartupWMClass, etc.). If absent, a
  reasonable handling is up to implementations (assuming false, using
  StartupWMClass, etc.). (See the Startup Notification Protocol
  Specification for more details).

https://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html

Also, some fields can be left empty according to Mk/bsd.port.mk:

  * Comment, Icon and StartupNotify may be empty
    strings (""). Categories may be an empty string in some
    cases (see below). The other fields are mandatory.
  * If Categories is an empty string, bsd.port.mk will try
    to deduce a default value using the CATEGORIES variable.
    If the deduction fails, you will have to set Categories
    manually. You should check the generated value using
    "make desktop-categories", and override it if necessary.

which would result in

  DESKTOP_ENTRIES=      "ZDoom" "" "" "${PORTNAME}" "" ""

but you may want to clarify category as "Game;Shooter;" per
https://standards.freedesktop.org/menu-spec/latest/apas02.html

-- 
You are receiving this mail because:
You are the assignee for the bug.