[Bug 213904] [maintainer] [patch] games/zdoom: Add desktop and pixmap files

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Tue Nov 8 14:37:50 UTC 2016


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=213904

Kyle Evans <bsdports at kyle-evans.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #176297|0                           |1
        is obsolete|                            |
 Attachment #176787|                            |maintainer-approval+
              Flags|                            |

--- Comment #2 from Kyle Evans <bsdports at kyle-evans.net> ---
Created attachment 176787
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=176787&action=edit
svn(1) diff of games/zdoom

Addressing concerns from jbeich@:

* Converted ${CP} to ${INSTALL_DATA} for the XPM
* Used DESKTOP_ENTRIES instead of a custom .desktop file

The shebang for the .desktop script, as far as I'm aware, is for potentially
oddball WMs that wouldn't necessarily execute the .desktop properly. That being
said, I don't have any strong feelings towards keeping it in given that
DESKTOP_ENTRIES doesn't bother including it -- I've gone ahead and converted
the .desktop file to its equivalent DESKTOP_ENTRIES entry, to be a bit more
standard.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-ports-bugs mailing list