[Bug 206654] sysutils/qjail speed up jail creation and other fixes

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206654

--- Comment #1 from Joe Barbish <qjail1 at a1poweruser.com> ---
Thank you Steven Hartland for taking the time and effort to submit your patch.
I am currently out of the country on a government contract which ends March 30
2016. I will not be able to address this until after then. 

My original plans are to wait until Release 11.0 is published because it's
suppose to included an updated VIMAGE that is included as part of the base
system. This will require testing of the qjail VIMAGE function that may result
in some changes.   

Change # 1. Previously assigned IP verification routine for ipv4 & ipv6.
In general I approval of what your trying to do. 

Change # 2. Increase the max duplication limit from 100 to 254. This value has
nothing to do with the max value in the last octal in ipv4 ip addresses. It
just controls the loop for automatically creating jails with the same jail name
prefix. The user must be aware of the starting ipv4 address stays valid when
bumped by 1 for each iteration of the duplication loop. The logic behind the
100 max value is to prevent the user from entering an erroneous value. In your
case of creating thousands of jails is unique. In general I see no problem of
increasing the max limit to 254.  

Change # 3. "Ignore missing definitions in some situations.
When running parallel qjail creates we we're seeing random failures due to
temporary definition files, which then disappeared. We deal with this by
allowing read-definition to fail." 

With out further testing research I can not accept your solution. To me, The
symptoms you are experiencing indicates that the same jail name is being
created by error during parallel creates. A review of the qjail create commands
being run through different terminal sessions need further inspection. Please
describe in greater detail just what your doing giving the qjail commands
issued that recreate the problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.