[Bug 206654] sysutils/qjail speed up jail creation and other fixes

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206654

            Bug ID: 206654
           Summary: sysutils/qjail speed up jail creation and other fixes
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: Individual Port(s)
          Assignee: freebsd-ports-bugs at FreeBSD.org
          Reporter: smh at FreeBSD.org
                CC: qjail1 at a1poweruser.com
             Flags: maintainer-feedback?(qjail1 at a1poweruser.com)

Created attachment 166162
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=166162&action=edit
Enhancements for qjail

I've been using qjail to create many jails (2k per machine) on some load test
hosts, during this we hit a few issues which we've fixed so wanted to pass on
the fixes.

The fixes where:
* Significantly improve performance of IP verification.
This check gets exponentially slower the more jails are added due to the load
of every previous jail config to validate it. We've changed this to a simple
grep which achieves the same thing in a fraction of the time.
* Refactor IP check to a single method.
With the above changes it was trivial to make a single method replace the
existing two.
* Increase the jail limit from 100 => 254 (max per subnet).
There didn't seem to be any reason for this limit so increased it such that an
entire subject of jails can be created.
* Fix output message typo.
* Ignore missing definitions in some situations.
When running parallel qjail creates we we're seeing random failures due to
temporary definition files, which then disappeared. Deal with this by allowing
read-definition to fail.


The patch is attached, hope its helpful.

-- 
You are receiving this mail because:
You are the assignee for the bug.