ports/63282: [NEW PORT] x11-toolkits/gtk-qt-engine

[Danny Pansters]

On Thursday 18 March 2004 18:43, you wrote:
> Synopsis: [NEW PORT] x11-toolkits/gtk-qt-engine
>
> State-Changed-From-To: open->feedback
> State-Changed-By: arved
> State-Changed-When: Thu Mar 18 09:43:11 PST 2004
> State-Changed-Why:
> Does not build on STABLE:
>
> gcc -DHAVE_DLFCN_H=1 -DSTDC_HEADERS=1 -I. -I. -I/usr/local/include/atk-1.0
> -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include
> -I/usr/X11R6/include/gtk-2.0 -I/usr/X11R6/lib/gtk-2.0/include
> -I/usr/X11R6/include/pango-1.0 -I/usr/X11R6/include
> -I/usr/local/include/freetype2 -I/usr/local/include -I/usr/X11R6/include/
> -I/usr/local/include -I/usr/X11R6/include -I/usr/X11R6/include -D_GETOPT_H
> -O -pipe -march=k6 -Wp,-MD,.deps/qt_theme_draw.pp -c qt_theme_draw.c       
> -fPIC -DPIC -o qt_theme_draw.lo qt_theme_draw.c: In function `draw_shadow':
> qt_theme_draw.c:302: syntax error before `*'
> qt_theme_draw.c:323: `gc1' undeclared (first use in this function)
> qt_theme_draw.c:323: (Each undeclared identifier is reported only once
> qt_theme_draw.c:323: for each function it appears in.)
> qt_theme_draw.c:323: `gc2' undeclared (first use in this function)
>
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=63282

Author David Sansome <me AT davidsansome.com> suggested that the build error 
might be caused by gdk not being included "whereas it is probably included by 
default in your version of GTK". 

It shouldn't make any difference if it's on -CURRENT or -STABLE anyway because 
ports are always a HEAD. I tested with and without the patch below 
pkg_deinstall'ing gtk and then have it be pulled in and built via this port. 
No probs.

I'm thinking that this may have been a temporary problem with the gtk port. 
Could someone test this on -STABLE, both with and without the below patch 
which explicitly includes gdk? I don't have a spare box to test with -STABLE.

workstation# cat files/patch-qt_theme_draw.c
--- qt_theme_draw.c.orig        Mon Feb  9 19:50:12 2004
+++ qt_theme_draw.c     Tue Mar 30 02:09:08 2004
@@ -1,5 +1,6 @@
 #include <math.h>
 #include <string.h>
+#include <gdk/gdk.h>
 #include <gtk/gtkprogressbar.h>
 #include <gtk/gtkrange.h>
 #include <gtk/gtknotebook.h>

Dan

(CC'd to arved and David; also gnats ports/63282 -- Hope I didn't over-CC)