requst for review: PR/61621

[Sergey Skvortsov]

Mathieu Arnold wrote:

> |> And you should define ALL_TARGET?= build so that it has a resonable
> |> default I guess.
> | 
> | Empty target also works.
> 
> It would tell people what the default target should be in case they want to
> do as they do for regular perl ports ALL_TARGETS="all test" they'll know
> that it's not "all" but "build".

Agree.

> |> And, you'll have to account for M::B build process, it should use
> |> PERL_MODBUILD=yes, but it should not depend on M::B, or it'll kinda loop
> |> :)
> | 
> | p5-Module-Build should use usual "PERL_CONFIGURE" and redefine
> | do-(build|install).
> | 
> | Special check for portname 'p5-Module-Build' in bsd.port.mk is overkill
> | and must be avoided.
> 
> That would lead to code dupplication, I don't believe it's good, but well,
> if you think it's better this way :)

There will be no checking for portname on _every_ port.

-- 
Sergey Skvortsov
mailto: skv at protey.ru