requst for review: PR/61621

[Mathieu Arnold]

+-le 21/01/2004 18:06 +0300, Sergey Skvortsov écrivait :
| Mathieu Arnold wrote:
|> |> They are the only ones needed, and I've not seen yet a modules that
|> |> only comes with only a Build.PL and no passthrough Makefile.PL.
|> | 
|> | There is no guarantee.
|> | And I suppose building modules via Module::Build has some advantages.
|> 
|> Well, the Makefile.PL are just passthrough that run perl Build.PL, and
|> generate a makefile that will call perl Build. When I started with M::B,
|> I redefined do-build and do-install... But I felt it easier to maintain
|> to just use the passthrough Makefile. You're right, there is no
|> guarantee that it will always be, but it has been so far :)
| 
| This patch is intended to naturally support Module::Build-driven ports.

Yes, I quite see that :)
Bear in mind that when I started, M::B interface was still changing a lot,
and it was easyer just to use the Makefile.PL passthrough.

| The next step - move all perl-related stuff into bsd.perl.mk.
| So the minimization of handling logic is not so important.
| And all new logic also will be moved into new .mk

That sounds really good, I've been thinking about something like that for
some time now.

|> And you should define ALL_TARGET?= build so that it has a resonable
|> default I guess.
| 
| Empty target also works.

It would tell people what the default target should be in case they want to
do as they do for regular perl ports ALL_TARGETS="all test" they'll know
that it's not "all" but "build".

|> And, you'll have to account for M::B build process, it should use
|> PERL_MODBUILD=yes, but it should not depend on M::B, or it'll kinda loop
|> :)
| 
| p5-Module-Build should use usual "PERL_CONFIGURE" and redefine
| do-(build|install).
| 
| Special check for portname 'p5-Module-Build' in bsd.port.mk is overkill
| and must be avoided.

That would lead to code dupplication, I don't believe it's good, but well,
if you think it's better this way :)

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-perl/attachments/20040121/131dc089/attachment.bin