[Differential] D24989: netinet: Generate a random RSS key on boot.

melifaro (Alexander V. Chernikov) phabric-noreply at FreeBSD.org
Mon May 25 22:04:37 UTC 2020


melifaro added inline comments.

INLINE COMMENTS

> rss_config.c:251
>  	 */
> +	arc4random_buf(&rss_key, RSS_KEYSIZE);
>  }

Are we sure that there is enough entropy available at the moment of calling it?

REPOSITORY
  rS FreeBSD src repository

CHANGES SINCE LAST ACTION
  https://reviews.freebsd.org/D24989/new/

REVISION DETAIL
  https://reviews.freebsd.org/D24989

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: neel_neelc.org
Cc: debdrup, rwatson, imp, ae, melifaro, #contributor_reviews_base, freebsd-net-list, mmacy, kpraveen.lkml_gmail.com, marcnarc_gmail.com, simonvella_gmail.com, novice_techie.com, tommi.pernila_iki.fi, krzysztof.galazka_intel.com


More information about the freebsd-net mailing list