[Differential] D10485: Replace dhcp option 150 by 66

Wed May 3 10:41:10 UTC 2017

tsoome added a comment.

  In https://reviews.freebsd.org/D10485#219375, @kczekirda wrote:

  > @tsoome 
  >  I based on the Intel's PXE Specification and there 66 exists.
  >
  > Nevermind, let's focus on the root-path. If we cannot use prefix tftp, maybe it can be a suffix? iPXE ignores bad root-path like: "192.168.22.19:/:tftp"
  >
  > F1206360: Screenshot at 2017-05-03 11:50:10.png <https://reviews.freebsd.org/F1206360>

  Specifications are nice, but as shown from the vmware case, you really can not assume they are followed. For the root path - the suffix idea is messy - I would really keep the root path very plain and simple, it is too easy to mess up the configurations otherwise.  Also, I think the best solution really is just to make the dhcp query with options 66 and 150 listed, so the existing setups with 150 will continue to work, 66 may be preferred (but has issue if someone is using the name, as discussed earlier). Also note that the ability to reuse PXE packet is really not much win anyhow, the UEFI case is kind of forced to issue dhcp request anyhow - at least I was not able to fetch the pxe ACK when simplenetwork API is used - I actually did try to see if it is possible.  And I think there is more value from having simple clear implementation for network setup, than attempting to save a bit for one single platform and trying to implement some other hacks. Note the https://reviews.freebsd.org/D10232 does nuke the BIOS pxe specific code and is switching to generic common/dev_net.c

REVISION DETAIL
  https://reviews.freebsd.org/D10485

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: kczekirda, bapt, oshogbo, tsoome, sbruno, #network, freebsd-net-list, imp, jhb
Cc: rgrimes, garga, ler, asomers