m_get2() name

Alfred Perlstein bright at mu.org
Fri Feb 1 12:40:10 UTC 2013


On 2/1/13 7:04 AM, Gleb Smirnoff wrote:
>    Hi!
>
>    The m_get2() function allocates a single mbuf with enough space
> to hold specified amount of data. It can return either a single mbuf,
> an mbuf with a standard cluster, page size cluster, or jumbo cluster.
>
>    It is alredy utilized in pfsync, bpf, libalias and soon to be utilized
> in ieee802111. There are probably more places in stack where it can be used.
>
>    The question is about its name. Once introduced, I just gave it name
> "m_get2" to avoid discussion with myself about bikeshed colour and continue
> hacking. Now it is getting used wider, and before we branch any stable branch
> off the head, we have last chance to rename it to smth more meaningful.
>
>    Any ideas on better name are welcome.
>
m_getbs - mbuf get buffer size.

conveniently also maps to:

m_getbs - mbuf get bike shed.

This is a cool function.  Maybe it should take an int*error arg as well 
for ENOBUFS/EINVAL?

-Alfred


More information about the freebsd-net mailing list