[ed] link state constantly going down and up

[miki miki]

Hi,

I have a problem with a D-Link DFE-670TXD which is handled by if_ed :
the link state is constantly going down and up :
Apr 28 14:21:33 iut-mir-o kernel: ed0: link state changed to DOWN
Apr 28 14:21:35 iut-mir-o kernel: ed0: link state changed to UP
Apr 28 14:21:40 iut-mir-o kernel: ed0: link state changed to DOWN
Apr 28 14:21:42 iut-mir-o kernel: ed0: link state changed to UP
Apr 28 14:22:51 iut-mir-o kernel: ed0: link state changed to DOWN
Apr 28 14:22:53 iut-mir-o kernel: ed0: link state changed to UP

I've double checked that there are no wire/switch/hub problems.

The card used to work fine with previous version of FreeBSD,
the problem appear with the following commit :
SVN rev 190643 on 2009-04-02 16:58:45Z by imp (CVS rev 1.126)
I do not see any link state change if I revert the commit.

FreeBSD [hostname] 8.0-CURRENT FreeBSD 8.0-CURRENT #6 r191614M:
Tue Apr 28 07:57:07 CEST 2009  user at hostname:/usr/obj/usr/src/sys/LETHE
amd64

ed0: <D-Link DFE-670TXD> at port 0x100-0x11f irq 19 function 0 config 32 on
pccard0
ed0: WARNING: using obsoleted if_watchdog interface
ed0: Ethernet address: 00:0d:88:21:54:e2
miibus1: <MII bus> on ed0
nsphyter0: <DP83815 10/100 media interface> PHY 1 on miibus1
nsphyter0:  10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, auto

dev.ed.0.type: DL10022
dev.ed.0.TxMem: 4608
dev.ed.0.RxMem: 19968
dev.ed.0.Mem: 24576
dev.ed.0.%desc: D-Link DFE-670TXD
dev.ed.0.%driver: ed
dev.ed.0.%location: function=0
dev.ed.0.%pnpinfo: manufacturer=0x0149 product=0x4530 cisvendor="D-Link"
cisproduct="DFE-670TXD" function_type=6
dev.ed.0.%parent: pccard0

Should I submit a PR ?

Thanks for your support,
Miki