Vimage virtual networking and 7.0

[Julian Elischer]

Bruce M. Simpson wrote:
> Julian Elischer wrote:
>>
>> In the future I am hoping to be able to use vimage in our products.
>> They are based at the moment on 6.1, but I can see in a year they will 
>> be based on 7.x.
>>
>> Patches for 7.0 and vimage are currently available in perforce.
>> What I would like to see is if there are any parts of that patch that
>> would allow us to make adding of vimage to 7.1 an easier task.
>>
>> For example, Anything that would prevent vimage from
>> needing an API change that would prevent it from being added later.
> 
> My concern is that this may have already happened. I've been trying to 
> do my bit as the years edge on to clean up the networking stack and fix 
> bugs. One of my concerns is that the vimage change, which attempts to 
> take network stack globals and wrap them into one big structure, may 
> intrude on this or be subject to bitrot due to other development.
> 
> 
>>
>> I am quite disappointed that despite Marko's best efforts, we miss the 
>> 7.0
>> release but if it can be made nonintrusive enough I'd really like to 
>> see if it can get in 7.1.
>>
> 
> I appreciate all the hard work Marko has done on this, though I wonder 
> if even 7.1 is ambitious.
> 
>> Personally, if I were "god" I'd put it in now because it can be 
>> compiled out.
>> and it wouldn't be compiled by default.Maybe only just bits of it..
>> for sure I want the ability to have many routing tables.
>> and I'm not thrilled about the requirement to have my own patch sets 
>> for this and thus not allowing others to use this feature.
> 
> I think there are deeper issues in the network stack overall which need 
> to be addressed, such as our lack of support for multipathing, scoped 
> addresses, and all the tidyups which need to happen in struct ifnet to 
> deal with this.
> 
> My concern is that vimage may be a very intrusive change indeed where 
> these matters are concerned, unless the vimage patches are being kept 
> up-to-date and regression tested as issues are resolved and new features 
> added.

This is axectly why I think they should go in now.
Remembering that they compile out to non changes..

Marko will I believe continue to keep up with -current as changes are made there.
however it would be easier if they were in the tree so that people MAKING 
the new changes just took it into account when they did it.

Similarly it will be a lot harder to backport to 7.x unless we keep a a separate 
7.x + vimage branch in p4 however that means that marko will need 
to do everything twice.

> 
> BMS
> _______________________________________________
> freebsd-net at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-net
> To unsubscribe, send any mail to "freebsd-net-unsubscribe at freebsd.org"