Problem with recent multimedia/handbrake and multimedia/x265 updates

[Kurt Jaeger]

Hi!

> Then Kurt added a build conflict with multimedia/x265.
> 
> Why?

In https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199126
you find more details about it.

> It does not use of depend on the x265 port, but it IS a problem. The
> build is pulling in /usr/local/include/x265.h which is significantly
> different in the new version of x265, especially in the definition of the
> x265_param structure, and that breaks the build. It should be using the
> version if x265.h in
> work/HandBrake-0.10.1/build/contrib/x265/x265-9329-0d30d2641875-1.5/source/
> but it looks like the appropriate '-I' is not used when building. I looked
> around for where this might be set, but did not find it. I really don't
> understand cmake.

We had someone reporting a problem (in that PR) and a solution,
which is not perfect. So I choose to at least document that solution
with the patch suggested by Keith White. If there's a better fix,
someone has to provide it, given the time and skill constrains we all
have.

> ATM, this is just a bit pain in the ass as it is not hard to work around,
> but it would be nice to have it fixed as the proper procedure may not be
> obvious to some:
> pkg delete -f x265
> build and install handbrake
> re-install x265
> This should probably have been added to UPDATING.

This is the generic fix for build conflicts, and because it's
the generic fix, it was not added to UPDATING.

This should not say this went all fine, but it went so-lala given
the contrains we work under. I'm sorry that it caused trouble 8-(

-- 
pi at opsec.eu            +49 171 3101372                         5 years to go !