Small change to top

Stephen Montgomery-Smith stephen at math.missouri.edu
Fri Jun 13 04:54:47 UTC 2008


top doesn't get TIME right for threaded processes.  How about this small 
change:

--- usr.bin/top/machine.c-orig	2008-06-12 23:06:08.000000000 -0500
+++ usr.bin/top/machine.c	2008-06-12 23:06:51.000000000 -0500
@@ -725,6 +725,7 @@
  			prev_pp = pp;
  		} else {
  			prev_pp->ki_pctcpu += pp->ki_pctcpu;
+			prev_pp->ki_runtime += pp->ki_runtime;
  		}
  	}


(Sorry if the mail client messes up the patch, but it is so short that 
it can be easily entered by hand.)

I do realize that this is not foolproof, because it won't measure any 
threads that have finished.  But it is perhaps a bit better than the 
current state of affairs, which randomly picks a runtime of one of the 
threads.



More information about the freebsd-hackers mailing list