Port upgrade: www/firefox. Added GUI selection support

[Adam Weinberger]

jannisan at t-online.de wrote:
> Hello.
> 
> Here is a patch for the www/firefox port adding the ability
> to let the user select which GUI to use by "make config".
> 
> He can choose between Xlib, Gtk1 and Gtk2 (default).
> Furthermore XUL can be disabled.
> 
> I hope I did it right. If the patch is approved maybe another patch will
> follow, enabling more facilities to configure the software installation.
> 
> Thanks
> Jan

Huh? This is ridiculous. Why would our user base want the ability to 
disable XUL? And why would the majority of our users want the ability to 
build against GTK1? We're trying to get people as far away from GTK1 as 
possible. And IIRC, firefox won't build against Xlib anyway and will 
ignore such a request and build against GTK2 anyway.

If a user wants to disable XUL for some reason, he or she can. But 
cluttering up the OPTIONS menu to disable something like XUL is 
pointless, unless disabling XUL does more than I think (which it very 
well might, in which case please give me some more info). Just because 
it can be disabled doesn't mean every single firefox user needs to be 
confronted with the choice to do so.

If you want to add OPTIONS, make them for experimental features or 
something.

# Adam


-- 
Adam Weinberger
adamw at magnesium.net || adamw at FreeBSD.org
adamw at vectors.cx    ||   adamw at gnome.org
http://www.vectors.cx