[RFC] [patch] periodic status-zfs: list pools in daily emails

[Glen Barber]

Hi Alexander,

On 6/29/11 4:46 AM, Alexander Leidinger wrote:
>> I added a default behavior to list the pools on the system, in
>> addition to
>> checking if the pool is healthy.  I think it might be useful for
>> others to
>> have this as the default behavior, for example on systems where dedup is
>> enabled to track the dedup statistics over time.
> 
> I do not think this is a bad idea to be able to see the pools... but
> IMHO it should be configurable (no strong opinion about "enabled or
> disabled by default").
> 

Agreed.  I can add this in.

>> The output of the the script after my changes follows:
> 
> Info to others: this is the default output, there is no special option
> to track DEDUP.
> 
>> Checking status of zfs pools:
>> NAME     SIZE  ALLOC   FREE    CAP  DEDUP  HEALTH  ALTROOT
>> zroot    456G   147G   309G    32%  1.00x  ONLINE  -
>> zstore   928G   258G   670G    27%  1.00x  ONLINE  -
>> all pools are healthy
>>
>> Feedback would be appreciated.  A diff is attached.
> 
> Did you test it with an unhealthy pool? If yes, how does the result look
> like?
> 

I have not, yet.  I can do this later today by breaking a mirror.

> For the healthy case we have redundant info (but as the brain is good at
> pattern matching, I would object to replace the status with the list
> output, in case someone would suggest this). In the unhealthy case we
> will surely have more info, my inquiry about it is if an empty line
> between the list and the status would make it more readable or not.
> 

I will reply later today with of the script with an unhealthy pool, and
will make listing the pools configurable.  I imagine an empty line would
certainly make it more readable in either case.  I would be reluctant to
replace 'status' output with 'list' output for healthy pools mostly to
avoid headaches for people parsing their daily email, specifically
looking for (or missing) 'all pools are healthy.'

Regards,

-- 
Glen Barber | gjb at FreeBSD.org
FreeBSD Documentation Project