kern/144330: [nfs] mbuf leakage in nfsd with zfs

[Kai Kockro]

Hi,

after 3 days with the first patch ( FreeBSD 8-STABLE AMD64, old nfsd ):

netstat -m
5732/10528/16260 mbufs in use (current/cache/total)
4825/10131/14956/262144 mbuf clusters in use (current/cache/total/max)

It looks very fine. I'll patch with the final corrections and then test again.

But why i have the same issues? I dont use UDP connects, only TCP?!

Greetings,
Kai


Am Dienstag, 23. März 2010 14:34:39 schrieb Rick Macklem:
> On Tue, 23 Mar 2010, Daniel Braniss wrote:
> >> I only have a FreeBSD client at this point, and it doesn't cause the
> >> leak for nfsv3,udp for me here.
> >
> > my client is also FreeBSD 8.0, strange
> 
> I was already using the patch below when I tested and couldn't see it,
> so I guess it now appears that the patch works.
> 
> >> Doug Rabson pointed out that there would be a leak for the "default:"
> >> case too, although didn't know if that would occur in practice.
> >
> > it does! :-)
> >
> >> So, maybe you could test this variant of the patch (just in case that
> >> was the slow leak...):
> >> --- rpc/svc.c.sav	2010-03-21 18:46:20.000000000 -0400
> >> +++ rpc/svc.c	2010-03-22 19:00:17.000000000 -0400
> >> @@ -819,9 +819,11 @@
> >>   					free(r->rq_addr, M_SONAME);
> >>   					r->rq_addr = NULL;
> >>   				}
> >> +				m_freem(args);
> >>   				goto call_done;
> >>
> >>   			default:
> >> +				m_freem(args);
> >>   				goto call_done;
> >>   			}
> >>   		}
> >
> > that plugged it!
> > see
> > 	ftp://ftp.cs.huji.ac.il/users/danny/freebsd/mbuf-leak/store-02+++.ps
> 
> Good work with the testing. I'll get it committed and put it up on the
> nfs patches page I have under http://people.freebsd.org/~rmacklem
> 
> > thanks to you for taking time off of your retirement :-)
> 
> I plan on doing quite a bit of FreeBSD/NFS stuff during it, rick
>