The patch delete no umount eject flash disk freebsd panic

[Eric Anderson]

On 02/21/07 03:55, Alexey Karakuts wrote:
>  #The patch delete flash disk freebsd panic
> #Any questions send email sys at bsdportal.ru Alexey N. Karakuts
> --- /sys/geom/geom_vfs.c        Mon Mar 13 03:05:29 2006
> +++ geom_vfs.c  Wed Dec  6 19:42:46 2006
> @@ -70,16 +70,9 @@
>        struct buf *bp;
>        int vfslocked;
> 
> -       if (bip->bio_error) {
> -               printf("g_vfs_done():");
> -               g_print_bio(bip);
> -               printf("error = %d\n", bip->bio_error);
> -       }
>        bp = bip->bio_caller2;
>        bp->b_error = bip->bio_error;
>        bp->b_ioflags = bip->bio_flags;
> -       if (bip->bio_error)
> -               bp->b_ioflags |= BIO_ERROR;
>        bp->b_resid = bp->b_bcount - bip->bio_completed;
>        g_destroy_bio(bip);
>        vfslocked = VFS_LOCK_GIANT(((struct mount *)NULL));
> 


So what happens when you have a regular drive fail then?  Or yank a SATA 
or other drive out from under the OS?

This patch seems awfully dangerous to me..

Eric