newfs: useless/bogus check if new last block can be accessed?

Poul-Henning Kamp phk at phk.freebsd.dk
Fri May 9 15:40:26 PDT 2003


In message <20030510002107.T638 at korben.in.tern>, Lukas Ertl writes:

>I don't think it does any harm to keep it (WRT to getting a working
>filesystem), but since I don't see how it would signal an error (and this
>is why I posted the question) I'd vote for removing the check.
>
>And while we're here: shouldn't wtfs() actually give a return value and
>not be just static void? (In terms of: "be a good programmer and check the
>return values of your syscalls...") I think it's called often enough in
>newfs to qualify for a check :-)

Get in touch with jmallett at freebsd.org who has been actively trying to
improve the UFS/FFS tools for some time, it sounds like the two of you
are on the same page :-)

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.


More information about the freebsd-fs mailing list